Repository navigation
Review follow-ups: fail loudly on bad config, --json on usage errors, doctor hints - #50
Merged
Merged
Conversation
Runtime dependencies are pinned exactly, but transitive ones are not; the lock makes uv sync --frozen reproduce the tested environment.
Reinstalling the same torch version from the cu126 index needs --force-reinstall (pip) or --reinstall-package (uv). For CUDA 12 builds the only fix is a newer driver, since gpuma pins torch.
- Explicit config paths must exist; examples resolve paths from their own directory. - memory_scaling_factor must be > 1 and max_memory_padding within [0.05, 0.95]. - SevenNet D3 rejects non-BJ damping and warns for omol25_* modals. - Only fairchem models with the omol task are accepted. - config --create writes the defaults and refuses to overwrite. - --json prints a summary for argparse usage errors too. - Docs: --json keys, uv tool install with the cu126 index, --model-type, edit link, and smaller fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the review after #49. No version bump yet.
Fail loudly instead of falling back
load_config_from_file(path)raises when an explicit path doesn't exist. Before, it silently used the defaults, so the example scripts ran their ORB sections with UMA when started outsideexamples/. Called with no path, it still reads./config.jsonif present and uses the defaults otherwise. The examples now resolve their configs and inputs from their own directory.memory_scaling_factormust be greater than 1, because otherwise the probe never grows.max_memory_paddingmust lie between 0.05 and 0.95. Both bounds are in the JSON Schema too.omol25_*modal logs the same double-counting warning as the other ωB97M-V models.*-omolmodels. r2scan, OC25 and ODAC25 are rejected.model_pathcheckpoints.config --createwrites the built-in defaults. It used to write the loaded./config.jsontogether with the CLI overrides. It now refuses to overwrite an existing file.--jsonerror.typeUsageError, so--jsonalways gives exactly one JSON object.checks,recommended_device,schemaandinstalled.doctor
--force-reinstall(pip) or--reinstall-package torch(uv). Without it, installing the same version is a no-op.Docs and housekeeping
uv.lockis tracked, souv sync --frozenreproduces the tested environment.docs/agents.mdinstalls the tool with the cu126 index. This was tested on driver 535 and givestorch 2.13.0+cu126with CUDA.--model-typealone doesn't pick an ORB model name.--multiplicityhelp text.master.--python 3.12inindex.md.Testing
mkdocs build --strictpasses.uma-s-1p2p1-ft-d4revworks in both paths, with matching energies.